Skip to content

(fix: #2884) iOS NFC: Ensure that Session is closed when an error causes it to become invalid #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2025
Merged

(fix: #2884) iOS NFC: Ensure that Session is closed when an error causes it to become invalid #2885

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf2b4b0
fix- call closeSession() when error cause session to become invalid
zaphim12 Jul 31, 2025
d5910d0
Create nfc-close-session.md
FabianLars Aug 1, 2025
f514876
Merge branch 'v2' into fix/nfc/ios/write-session
zaphim12 Aug 1, 2025
5935caf
just use session = nil since the session is already invalidated
zaphim12 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/nfc-close-session.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
nfc: patch
nfc-js: patch
---

On iOS, the reader session will now get closed properly on errors, preventing dangling invalid sessions that could prevent subsequent write attempts.
2 changes: 2 additions & 0 deletions plugins/nfc/ios/Sources/NfcPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ class NfcPlugin: Plugin, NFCTagReaderSessionDelegate, NFCNDEFReaderSessionDelega

func tagReaderSession(_ session: NFCTagReaderSession, didInvalidateWithError error: Error) {
Logger.error("Tag reader session error \(error)")
self.closeSession(session, error: "Tag reader session error: \(error)")
self.session?.invoke.reject("session invalidated with error: \(error)")
}

Expand Down Expand Up @@ -199,6 +200,7 @@ class NfcPlugin: Plugin, NFCTagReaderSessionDelegate, NFCNDEFReaderSessionDelega
Logger.debug("readerSessionInvalidationErrorFirstNDEFTagRead")
} else {
Logger.error("NDEF reader session error \(error)")
self.closeSession(session, error: "NDEF reader session error: \(error)")
self.session?.invoke.reject("session invalidated with error: \(error)")
}
}
Expand Down
Loading