feat(dialog) - Support picker mode for open dialog (#3030) #3034
+113
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 27c84dfThere are 12 changes which include deep-link with patch, deep-link-js with patch, dialog with minor, dialog-js with minor, fs with patch, fs-js with patch, geolocation with patch, geolocation-js with patch, opener with patch, opener-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
onehumandev
force-pushed
the
aldewaal/picker-mode
branch
from
27c84df to
845795e
Compare
velocitysystems
suggested changes
Oct 14, 2025
onehumandev
force-pushed
the
aldewaal/picker-mode
branch
3 times, most recently
from
d8f48b8 to
b1b6214
Compare
For iOS and Android, there are 2 distinct file picker dialogs, one for picking media and one for picking documents. Previously, the filters provided by the user would determing which picker would be displayed. However, this has led to undefined behavior when no filter was provided. To resolve this, we now provide a PickerMode (meant for iOS and eventually Android) to explicitly define which picker we want to display. Eventually, we may need to provide more explicit ways of filtering by MIME type or having specific modes for ImagePicker or VideoPicker for ease of use on mobile platforms. But for now, this is an initial implementation that allows specifying which UI would be preferable for a file picker on mobile platforms.
onehumandev
force-pushed
the
aldewaal/picker-mode
branch
from
b1b6214 to
1407271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For iOS and Android, there are 2 distinct file picker dialogs, one for picking media and one for picking documents.
Previously, the filters provided by the user when calling the
openmethod would determine which picker would be displayed.However, this has led to undefined behavior when no filter was provided.
To resolve this, we now provide a PickerMode (meant for iOS and eventually Android) to explicitly define which picker we want to display.
Eventually, we may need to provide more explicit ways of filtering by MIME type or having specific modes for ImagePicker or VideoPicker for ease of use on mobile platforms.
But for now, this is an initial implementation that allows specifying which UI would be preferable for a file picker on mobile platforms.
Related bug #3030