-
Notifications
You must be signed in to change notification settings - Fork 425
feat: Add KeepSome to log plugin #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks so much for contributing and sorry for the huge delay!
I'll do a proper review tomorrow but wanted to ask you for a changefile similar to https://github.com/tauri-apps/plugins-workspace/blob/v2/.changes/dialog-async-message-dialog.md already.
@FabianLars @kris-ava Just wanted to circle back on this. I to have a use case where i don't want to keep "everything" but simply the last X days. Also maybe a version 1 port :) |
Looks like this has been sitting a while! Is there any chance this could be backported to V1? |
We mostly stopped backporting features to v1, but we're still looking at community PRs that do so. |
Thanks for the speedy response @FabianLars - I may open a PR to do so in the near future if @kris-ava is not interested in doing so themselves as this feature is something I'd love to be able to use before V2 is ready for production use! |
@FabianLars Can we please make it to get it into the next release? |
Package Changes Through a5a79ddThere are 6 changes which include updater with minor, updater-js with minor, autostart with minor, autostart-js with minor, log with minor, log-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry for the delay again
Allows users to only keep some of the old plugins (thus making sure that logging does not hog all available disk space)