Skip to content

chore(windows): downgrade eventloop warnings #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Legend-Master merged 3 commits into from
Feb 20, 2026
Merged

chore(windows): downgrade eventloop warnings #1189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ac6717
chore(windows): downgrade warnings
thomaseizinger Feb 19, 2026
2346f05
Add change-file
thomaseizinger Feb 20, 2026
b69a464
Add TODOs
thomaseizinger Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/downgrade-warnings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tao": patch
---

Downgrades several logs in the Windows backend from WARN to DEBUG.
9 changes: 6 additions & 3 deletions src/platform_impl/windows/event_loop/runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ impl<T> EventLoopRunner<T> {
pub(crate) unsafe fn send_event(&self, event: Event<'_, T>) {
if let Event::RedrawRequested(_) = event {
if self.runner_state.get() != RunnerState::HandlingRedrawEvents {
warn!("RedrawRequested dispatched without explicit MainEventsCleared");
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
debug!("RedrawRequested dispatched without explicit MainEventsCleared");
self.move_state_to(RunnerState::HandlingRedrawEvents);
}
self.call_event_handler(event);
Expand Down Expand Up @@ -342,7 +343,8 @@ impl<T> EventLoopRunner<T> {
self.call_event_handler(Event::MainEventsCleared);
}
(HandlingMainEvents, Idle) => {
warn!("RedrawEventsCleared emitted without explicit MainEventsCleared");
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
debug!("RedrawEventsCleared emitted without explicit MainEventsCleared");
self.call_event_handler(Event::MainEventsCleared);
self.call_redraw_events_cleared();
}
Expand All @@ -356,7 +358,8 @@ impl<T> EventLoopRunner<T> {
self.call_redraw_events_cleared();
}
(HandlingRedrawEvents, HandlingMainEvents) => {
warn!("NewEvents emitted without explicit RedrawEventsCleared");
// TODO: Consider removing log once https://github.com/rust-windowing/winit/pull/2767 gets adopted.
debug!("NewEvents emitted without explicit RedrawEventsCleared");
self.call_redraw_events_cleared();
self.call_new_events(false);
}
Expand Down
Loading