-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(api): convert Position
to PhsyicalPosition
for TrayIconEvent
#11104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2093c8e
fix(api): convert `Position` to `PhsyicalPosition` for `TrayIconEvent`
amrbashir 0e49d7b
fix lint
amrbashir d09bd9a
Merge branch 'dev' into fix/api/positon-to-physicalposition
amrbashir c5ebd17
Merge branch 'dev' into fix/api/positon-to-physicalposition
amrbashir 03041ac
Add missing `doubleClick` event type
amrbashir 3d77ba2
change file
amrbashir 431e90d
update lockfile
amrbashir 50ec479
Update .changes/api-tray-icon-event-value-mismatch-type.md [skip ci]
lucasfernog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@tauri-apps/api": "patch:bug" | ||
--- | ||
|
||
Add missing `TrayIconDoubleClickEvent` type and `doubleClick` variant in `TrayIconEvent` type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@tauri-apps/api": "patch:bug" | ||
--- | ||
|
||
Fix inavlid value passed to the callback `action` function that doesn't match the `TrayIconEvent` type. | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,5 +25,10 @@ | |
"devDependencies": { | ||
"prettier": "^3.3.3" | ||
}, | ||
"packageManager": "[email protected]" | ||
"packageManager": "[email protected]", | ||
"pnpm": { | ||
"overrides": { | ||
"rollup@>=4.0.0 <4.22.4": ">=4.22.4" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.