feat(window): add drag-stopped and resize-stopped events using move/r… #14503
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Legend-Master
left a comment
Legend-Master
left a comment
There was a problem hiding this comment.
Seeing the limitation on this implementation, I think this should be done on user land or we'll need a more complete solution
| }) | ||
| } | ||
|
|
||
| window.addEventListener('tauri://resize', () => { |
Contributor
There was a problem hiding this comment.
This is not reliable to be honest
| const cmd = e.detail === 2 ? 'internal_toggle_maximize' : 'start_dragging' | ||
| window.__TAURI_INTERNALS__.invoke('plugin:window|' + cmd) | ||
| // maximize on double-clicking it, or start dragging on single click | ||
| if (e.detail === 2) { |
Contributor
There was a problem hiding this comment.
So I believe this only works for the dragging from our custom draggable region (data-tauri-drag-region)?
Author
There was a problem hiding this comment.
Thanks for the feedback, I will try to provide the complete solution using another approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(window-events): add drag-stopped and resize-stopped events
tauri://moveto detect when window dragging stopsusing a 150ms idle timeout.
tauri://resizeto detect resize-stop events.This closes [feat] Drag-stopped and resize-stopped event are needed #14489