Support for querying customers and updating their emails#19
Open
jorgemanrubia wants to merge 17 commits intotaxjar:masterfrom
Open
Support for querying customers and updating their emails#19jorgemanrubia wants to merge 17 commits intotaxjar:masterfrom
jorgemanrubia wants to merge 17 commits intotaxjar:masterfrom
Conversation
(cherry picked from commit 751c97f)
Adding this option to support passing query params when listing customers as per: https://developer.helpscout.com/mailbox-api/endpoints/customers/list/
jorgemanrubia
force-pushed
the
basecamp-additions
branch
2 times, most recently
from
87c7243 to
e3d11a7
Compare
jorgemanrubia
force-pushed
the
basecamp-additions
branch
from
e3d11a7 to
d2c1a3f
Compare
jorgemanrubia
changed the title
jorgemanrubia
force-pushed
the
basecamp-additions
branch
from
6f474d8 to
986e03f
Compare
2.4 version was the minimum for rubocop 0.93
|
|
|
I've made #25, maybe we can combine our efforts |
Fix 404 on folders path
* taxjar/master: allow faraday >= 2.7.4 bumping version to appease Rubygems create v3.0.0 create v3.0.0 [TJPLAT-1483] upgrade to faraday 2.9 for Ruby 3.x compatibiity Update version.rb Update help_scout-sdk.gemspec
* master: allow faraday >= 2.7.4 bumping version to appease Rubygems create v3.0.0 create v3.0.0 [TJPLAT-1483] upgrade to faraday 2.9 for Ruby 3.x compatibiity Update version.rb Update help_scout-sdk.gemspec Fix 404 on folders path Relax faraday dependencies Add method to update emails Add spec for passing query params to list customer queries Support passing params to list queries Relax faraday dependency version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds supports for two things:
Passing params for listing operations. I wanted to be able to use
queryparams when finding customers. I think supporting params in general forlistrequests makes sense.Support for customer email updates
It also includes some changes for making the travis build pass:
raketo deal with security advisory CVE-2020-8130 that was making Travis fail.Thanks for the nice lib!