hud_strafehelper.c bugfixes, refactors, cleanup#289
Merged
Conversation
f1ec894 to
4a18a76
Compare
cleanup: - Add const qualifiers to function parameters and local variables where applicable - Remove redundant parentheses - Reduce variable scope and move declarations closer to usage - Replace unnecessary temporaries and redundant else blocks - Use sqrtf, acosf, asinf, floorf consistently for float math - Minor formatting and readability improvements - Remove unused variables and dead code correctness: - Initialize conditional variables in DF_StrafeHelper - Remove duplicate airaccelerate assignment in DF_SetPhysics - Early return on division by zero in DF_GetCmdScale - Initialize scale in DF_GetWishspeed to avoid uninitialized use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup:
correctness:
fix: