Skip to content

Fix fetching genres #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jetrosuni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix fetching genres #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 19 additions & 24 deletions src/Imdb/Title.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ public function languages_detailed()
* @return string genre first of the genres listed on the movies main page
* @brief There is not really a main genre on the IMDB sites (yet), so this
* simply returns the first one
* @see IMDB page / (TitlePage)
* @see IMDB page /reference
*/
public function genre()
{
Expand All @@ -710,34 +710,29 @@ public function genre()

/** Get all genres the movie is registered for
* @return array genres (array[0..n] of strings)
* @see IMDB page / (TitlePage)
* @see IMDB page /reference
*/
public function genres()
{
if (empty($this->moviegenres)) {
$xpath = $this->getXpathPage("Title");
$extract_genres = $xpath->query("//li[@data-testid='storyline-genres']//li[@class='ipc-inline-list__item']/a");
$genres = array();
foreach ($extract_genres as $genre) {
if (!empty($genre->nodeValue)) {
$genres[] = trim($genre->nodeValue);
}
}
if (count($genres) > 0) {
$this->moviegenres = $genres;
}
}
if (empty($this->moviegenres)) {
$genres = isset($this->jsonLD()->genre) ? $this->jsonLD()->genre : array();
if (!is_array($genres)) {
$genres = (array)$genres;
}
$this->moviegenres = $genres;
$query = <<<EOF
query Genres(\$id: ID!) {
title(id: \$id) {
titleGenres {
genres {
genre {
text
}
if (empty($this->moviegenres)) {
if (@preg_match('!Genres:</h4>(.*?)</div!ims', $this->page["Title"], $match)) {
if (@preg_match_all('!href="[^>]+?>\s*(.*?)\s*<!', $match[1], $matches)) {
$this->moviegenres = $matches[1];
}
}
}
}
EOF;

$data = $this->graphql->query($query, "Genres", ["id" => "tt$this->imdbID"]);
if (isset($data->title->titleGenres->genres)) {
foreach ($data->title->titleGenres->genres as $genres) {
$this->moviegenres[] = $genres->genre->text;
}
}
}
Expand Down