fix: Apply end_context when end/exit is a sequence step#137
Merged
Conversation
lykinsbd
force-pushed
the
fix/scenario-end-context
branch
from
4319ce2 to
89670a5
Compare
In scenario mode, end and exit were blocked from applying their context effect because inScenario was still true after the sequence step advanced. Now explicitly apply handleExitEnd when the sequence step was end or exit.
lykinsbd
force-pushed
the
fix/scenario-end-context
branch
from
89670a5 to
5c41195
Compare
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scenario mode, end/exit were blocked from applying their context effect. Now explicitly apply handleExitEnd when the matched sequence step was end or exit.