Open
Conversation
Four spaces per indent, no trailing spaces, if/then on single line.
Owner
|
Thanks Elliot! I’ll review!
Tom
… On Jul 13, 2017, at 3:03 PM, Elliot Jordan ***@***.***> wrote:
Many of the changes I've made were suggested by Shellcheck <https://github.com/koalaman/shellcheck/wiki>, and a few are personal preferences. Take what you like, leave the rest!
You can view, comment on, or merge this pull request online at:
#23 <#23>
Commit Summary
Standardize whitespace
Use $(..) instead of legacy `..`
Remove trailing whitespace
For/do on one line, like if/then
Remove unused variables
No $echo var is defined
Catch failed `cd` commands
File Changes
M munkiinabox.sh <https://github.com/tbridge/munki-in-a-box/pull/23/files#diff-0> (263)
Patch Links:
https://github.com/tbridge/munki-in-a-box/pull/23.patch <https://github.com/tbridge/munki-in-a-box/pull/23.patch>
https://github.com/tbridge/munki-in-a-box/pull/23.diff <https://github.com/tbridge/munki-in-a-box/pull/23.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#23>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADfKRTdEjAXKE9qvLuxIoXqJekeGjoAks5sNmnygaJpZM4OXaUS>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the changes I've made were suggested by Shellcheck, and a few are personal preferences. Take what you like, leave the rest!