fix: improve gradle build cache stability #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by providing serializable objects attached to compileTasks
Author
|
@tbroyer Anything else I can do on my side? |
Owner
|
Did you bring the issue up to the Gradle team? I stand by my comment I'm afraid: AFAICT it's supposed to work, so if it doesn't it looks like a bug in Gradle (unless they say it's not actually supposed to work and provide guidance) and/or something specific to your environment. |
Author
|
I have not reached out to the gradle team, will do and report back here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I reported in #101 we have issues when using gradle remote build cache: Sometimes (not always) we get cache misses due to fingerprint differences for
options.compilerArgumentProviders.errorprone$0andoptions.compilerArgumentProviders.errorprone$0.errorproneOptions.I was not very successful with debugging the issue (it is non-trivial). Using the changes in this PR, I am no longer seeing these fingerprint differences between CI and developer machines. It has been consistently working for us for the last 100+ builds.
Feel free to deny this PR or request more changes if you don't feel confident about it @tbroyer