Normative: Add getOrInsert and getOrInsertComputed methods for Map and WeakMap #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
michaelficarra
approved these changes
Jan 5, 2026
bakkot
approved these changes
Jan 5, 2026
Member
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
Tiny nit: we mostly (although I guess not uniformly) use lowercase for section IDs.
Otherwise LGTM.
ljharb
added
normative change
Sorry, I was unable to apply the suggested changes directly from GitHub.
jmdyck
reviewed
Jan 7, 2026
spec.html
Outdated
|
|
||
| <emu-clause id="sec-map.prototype.getorinsert"> | ||
| <h1>Map.prototype.getOrInsert ( _key_, _value_ )</h1> | ||
| <p>When the getOrInsert method is called the following steps are taken:</p> |
Collaborator
There was a problem hiding this comment.
This is old phrasing.
Suggested change
| <p>When the getOrInsert method is called the following steps are taken:</p> | |
| <p>This method performs the following steps when called:</p> |
Likewise for the other 3 occurrences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Upsert proposal, I'm hoping to bring this for Stage 4 at an upcoming plenary.