Editorial: rename genContext to calleeContext in RunCallerContext - #3952
Editorial: rename genContext to calleeContext in RunCallerContext#3952Leonabcd123 wants to merge 1 commit into
Conversation
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
_innerContext_? As we have two contexts, it's good to have both of them qualified.
1c42935 to
1527c9d
Compare
Thinking a bit more about the name, I think |
|
Agreed that
We should maybe settle that naming question first. |
I get why For now I changed it to |
1527c9d to
e50e792
Compare
That's a possibility.
The caller/callee distinction normally arises with functions: function A calls function B, so A is the caller and B is the callee. But a transfer of control (in the sense of #2962) is not a function call, so it might be misleading to use the caller/callee terminology. (On the other hand, we might not find anything better.) |
|
Given #2962 rephrases these steps to use the phrasing "transfer control", I agree that caller/callee is not appropriate. I think we should choose names that work well with that phrasing. |
The running execution context in
RunCallerContext(step 1) is namedgenContext, even thoughRunCallerContextis also called fromAwait, so the context can also be just a normal async function rather than a generator, which makes the current name a bit confusing in my opinion. This pr renames it tocalleeContext.