Editorial: Make "structurally valid language tag" an auto-linked term #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nical" to "structurally valid" Canonicalization is already performed by MakeLocaleRecord, and not needed before it.
anba
requested changes
May 31, 2025
| @@ -27,7 +27,6 @@ <h1>Intl.Locale ( _tag_ [ , _options_ ] )</h1> | |||
| 1. Let _tag_ be ? ToString(_tag_). | |||
| 1. Set _options_ to ? CoerceOptionsToObject(_options_). | |||
| 1. If IsStructurallyValidLanguageTag(_tag_) is *false*, throw a *RangeError* exception. | |||
| 1. Set _tag_ to CanonicalizeUnicodeLocaleId(_tag_). | |||
There was a problem hiding this comment.
Removing canonicalisation is still a normative change: #804 (review)
There was a problem hiding this comment.
All right, that's twice now... this is clearly too subtle, so I've added an explanatory note.
…m "canonical" to "structurally valid"
…nicalization The relevant algorithms are buried rather deep in that section.
gibson042
changed the title
gibson042
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.