Skip to content

Adapt ToIntlMathematicalValue to handle initial numeric-like text #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessealama wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adapt ToIntlMathematicalValue to handle initial numeric-like text #73

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ca14d3
Adapt `ToIntlMathematicalValue` to handle initial numeric-like text
jessealama Nov 12, 2025
a0de853
Don't use internal slots in argument position
jessealama Nov 13, 2025
a9254fd
Naively clone options object rather than modify
jessealama Nov 13, 2025
01853f0
fix minor typographic bugs
jessealama Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions intl.emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,16 @@

<emu-alg>
1. Let _O_ be the *this* value.
1. Perform ? RequireInternalSlot(_O_, [[Decimal128Data]]).
1. Perform ? RequireInternalSlot(_O_, [[Value]]).
1. Let _amountUnit_ be _O_.[[Unit]].
1. Let _optionsUnit_ be _options_.[[unit]].
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reading an internal slot?

Copy link
Copy Markdown
Collaborator Author

@jessealama jessealama Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated things so that we no longer refer to an internal slot and, if necessary, create a fresh copy of options rather than potentially modifying it.

1. If _amountUnit_ is a String, then
1. If _optionsUnit_ is a String, then
1. If _amountUnit_ is not equal to _optionsUnit_, throw a *TypeError* exception.
1. Else,
1. Set _options_.[[unit]] to _amountUnit_.
1. Let _numberFormat_ be ? Construct(%Intl.NumberFormat%, &laquo; _locales_, _options_ &raquo;).
1. Return FormatNumeric(_numberFormat_, _O_.[[AmountData]]).
1. Return FormatNumeric(_numberFormat_, _O_.[[Value]]).
</emu-alg>
</emu-clause>
</emu-clause>
Expand Down Expand Up @@ -152,7 +159,7 @@
</dd>
</dl>
<emu-alg>
1. <ins>If _value_ has the [[Value]] and [[FractionDigits]] internal slots, let _primValue_ be RenderAmountValueWithFractionDigits(_value_.[[Value]], _value_.[[FractionDigits]]) else</ins><del>Let</del> <ins>let</ins _primValue_ be ? ToPrimitive(_value_, ~number~).
1. Let _primValue_ be ? ToPrimitive(_value_, <del>~number~</del><ins>~string~</ins>).
1. If _primValue_ is a BigInt, return ℝ(_primValue_).
1. If _primValue_ is a String, then
1. Let _str_ be _primValue_.
Expand All @@ -161,8 +168,10 @@
1. If _x_ is *-0*<sub>𝔽</sub>, return ~negative-zero~.
1. Let _str_ be Number::toString(_x_, 10).
1. Let _text_ be StringToCodePoints(_str_).
1. Let _literal_ be ParseText(_text_, |StringNumericLiteral|).
1. If _literal_ is a List of errors, return ~not-a-number~.
1. Let _trimmedText_ be the longest prefix of _text_ that satisfies the syntax of a |StringNumericLiteral|, which might be _text_ itself. If there is no such prefix, return ~not-a-number~.
1. NOTE: The previous step is a adapted from <emu-xref href="#sec-parsefloat-string">parseFloat</emu-xref>.
1. Let _literal_ be ParseText(_trimmedText_, |StringNumericLiteral|).
1. <del>If _literal_ is a List of errors, return ~not-a-number~.</del>
1. Let _intlMV_ be the StringIntlMV of _literal_.
1. If _intlMV_ is a mathematical value, then
1. Let _rounded_ be RoundMVResult(abs(_intlMV_)).
Expand Down