initial spec draft #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok for Stage 2. There are likely some issues we'll need to contend with for Stage 2.7... in particular, the behavior with circular sync imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posting up a very initial spec for early feedback.
The approach taken here is instead of reinventing all functions (
HostLoadImportedModuleSync/ContinueDynamicImportSync/FinishLoadingImportedModuleSyncetc etc), we instead replace the PromiseCapability with a CompletionRecord which can be dynamically mutated to effectively share the function paths for sync and async.This seems slightly simpler, although we need to weigh the pros and cons on a per spec method basis going forward.