Editorial: Add and use additional MonthCode AOs #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
reviewed
Aug 13, 2025
Co-authored-by: Richard Gibson <[email protected]>
gibson042
approved these changes
Aug 13, 2025
ptomato
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
👍
Just nitpicks.
Have a look at tc39/proposal-temporal#3144 and see if you agree with Richard's suggestion to merge ToMonthCode and ParseMonthCode. If so, you'll need to add a few ! accordingly.
Co-authored-by: Philip Chimento <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #69
Depends on tc39/proposal-temporal#3144
This turns some of the prose into algorithm steps while still leaving some of the prose in place. After this lands, I'll be able to refactor #69 to be more narrow in scope.