Skip to content

Editorial: Define and consistently use a "ISO 8601 / RFC 9557 string" term #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibson042
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (c150e71) to head (25ee59d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3115   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          21       21           
  Lines        9969     9969           
  Branches     1823     1823           
=======================================
  Hits         9655     9655           
  Misses        268      268           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ptomato
Copy link
Collaborator

ptomato commented May 27, 2025

I think we decided some time ago to refer to "RFC 9557" primarily, and call the grammar "ISO 8601 / RFC 9557". @justingrant Do you remember?

I don't have much of an opinion on this.

@gibson042
Copy link
Collaborator Author

RFC 9557 doesn't cover duration strings.

@justingrant
Copy link
Collaborator

Yep, that matches my memory too: use RFC 9557 as the primary term, and when we introduce it, call out its relationship to ISO 8601. We should probably also call out the relationship to RFC 3339.

@ptomato
Copy link
Collaborator

ptomato commented Jun 23, 2025

RFC 9557 doesn't cover duration strings.

I am pretty sure that we still refer to any duration strings as "ISO 8601" and not "RFC 9557".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants