Editorial: Various updates regarding Era/Month code #3142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptomato
commented
Aug 4, 2025
ptomato
commented
- Update reference code to match spec text changes from Editorial: Compute offsetBehaviour after parsing is complete #3134, Editorial: Split GetTemporalUnitValuedOption with ValidateTemporalUnitValue #3135, Fix: Allow auto in ValidateTemporalUnitValue #3139
- Reflect editorial changes that stage 2.7 reviewers of Intl Era/Month code asked for
The information here is all that's needed for ECMA-262, the rest will appear in the ECMA-402 section.
Clarify that this month code doesn't exist in any currently supported calendars, with "theoretically".
…spec The Burmese calendar is used as an example here of era year 0, but is not one of the CLDR calendars. Say "not currently available in CLDR" and not "not supported" because this text should be mirrored in Temporal where it is not required to be supported anyway.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 96.77% 96.78%
=======================================
Files 21 21
Lines 9992 10003 +11
Branches 1830 1830
=======================================
+ Hits 9670 9681 +11
Misses 276 276
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.