Skip to content

Editorial: Add note about hard-coded overflow constrain #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Editorial: Add note about hard-coded overflow constrain #3162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/plaindate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,7 @@ <h1>
1. If _sign_ × (_d1_ - _isoDate2_.[[Day]]) > 0, return *true*.
1. Return *false*.
</emu-alg>
<emu-note>This operation intentionally uses overflow ~constrain~ when regulating the year-month.</emu-note>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth explaining why we use ~constrain~ here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I can clearly explain why. It's just a choice we made for how the algorithm works. There are other choices that could have been made.

Do you want to try?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that @ptomato may have more recent knowledge than I do about this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it was actually added by @sffc here: #3138

It's been too long since I read Shane's proof in the comments of that PR, so I don't have context on it anymore.

</emu-clause>

<emu-clause id="sec-temporal-regulateisodate" type="abstract operation">
Expand Down