Thorough duration totalling tests #3200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we hardly had any tests with large numbers in the years, months, weeks, or days fields of durations, or non-calendar durations with days. This removes some of the randomly generated durations from the existing categories and adds randomly generated durations from the categories named above, so that makeDurationCases() has a mix of durations that are better distributed throughout the testing space. Also pulls each category of randomly generated durations out into its own array, and concats them in makeDurationCases(), to allow for adjusting the mix during debugging. Updates the snapshots accordingly.
Testing Temporal.Duration.prototype.total() with a variety of "interesting" durations, with relativeTo being various PlainDates, various ZonedDateTimes, or nothing. Tests the invariant that total() and round() should agree. This invariant actually does not hold in a surprising number of situations, but as far as I can tell that is correct per the specification and is due to floating-point precision loss which we have correctly accounted for.
ptomato
force-pushed
the
duration-total
branch
from
9e9906c to
8249519
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 22 22
Lines 10348 10348
Branches 1859 1859
=======================================
Hits 10011 10011
Misses 287 287
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Temporal.Duration.prototype.total()with a variety of "interesting" durations, with relativeTo being various PlainDates, various ZonedDateTimes, or nothing.Tests the invariant that total() and round() should agree. This invariant actually does not hold in a surprising number of situations, but as far as I can tell that is correct per the specification and is due to floating-point precision loss which we have correctly accounted for.
I also updated the "interesting" durations to be distributed a bit more over the full testing space, and updated the existing snapshot files accordingly.