Thorough tests for ISO-like calendar math #3201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: we run into a polyfill bug here that is fixed by #3199, so the CI won't pass until that PR has been merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 22 22
Lines 10348 10348
Branches 1859 1859
=======================================
Hits 10011 10011
Misses 287 287
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Splits test/thorough/gregorian.mjs into two new test files: - calendarisolike.mjs tests that the year and month differences for the four ISO-like calendars are equal to the same differences calculated in the ISO calendar. - calendardaymath.mjs tests that week and day differences for all non- ISO calendars (except, temporarily, 'chinese' and 'dangi') are equal to the same differences calculated in the ISO calendar. (Days are always equivalent, and weeks are always 7 days in all currently supported calendars.) This is in order to test the simplest invariants in other non-ISO calendars and not just 'gregory'.
ptomato
force-pushed
the
iso-like-calendar-tests
branch
from
2669387 to
f527f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits test/thorough/gregorian.mjs into two new test files:
calendarisolike.mjs tests that the year and month differences for the four ISO-like calendars are equal to the same differences calculated in the ISO calendar.
calendardaymath.mjs tests that week and day differences for all non-ISO calendars (except, temporarily, 'chinese' and 'dangi') are equal to the same differences calculated in the ISO calendar. (Days are always equivalent, and weeks are always 7 days in all currently supported calendars.)
This is in order to test the simplest invariants in other non-ISO calendars and not just 'gregory'.