Editorial: Adjust description of CalendarResolveFields #3244
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bit of the description was inaccurate. It's not fully possible to merge the [[Month]] and [[MonthCode]] fields in lunisolar calendars, without the overflow parameter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3244 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 22 22
Lines 10397 10397
Branches 1828 1828
=======================================
Hits 10126 10126
Misses 247 247
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…elds See tc39/proposal-intl-era-monthcode#107. This changes the general outline of the ISO8601 part of CalendarResolveFields so that it parallels the outline of NonISOResolveFields in the Intl Era Monthcode proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bit of the description was inaccurate. It's not fully possible to merge the [[Month]] and [[MonthCode]] fields in lunisolar calendars, without the overflow parameter.