Editorial: Refactor ISODateSurpasses parallel to NonISODateSurpasses #3245
+93
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
==========================================
- Coverage 97.94% 97.91% -0.03%
==========================================
Files 22 22
Lines 10401 10414 +13
Branches 1814 1824 +10
==========================================
+ Hits 10187 10197 +10
- Misses 196 199 +3
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
force-pushed
the
editorial-isodatesurpasses
branch
from
ff80068 to
eae02f2
Compare
Collaborator
Author
|
Updated this PR to make the non-ISO8601 calculations in the polyfill work according to the adopted normative change in proposal-intl-era-monthcode. |
See tc39/proposal-intl-era-monthcode#101. This changes the general outline of ISODateSurpasses so that it parallels the outline of NonISODateSurpasses in the Intl Era/Month Code proposal as proposed in the PR, and adds the CompareSurpasses operation. Also refactors the polyfill code, but keeps the optimizations we already had regarding not passing weeks and days to ISODateSurpasses.
ptomato
force-pushed
the
editorial-isodatesurpasses
branch
from
eae02f2 to
f407a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-intl-era-monthcode#101. This changes the general outline of ISODateSurpasses so that it parallels the outline of NonISODateSurpasses in the Intl Era Monthcode proposal as proposed in the PR.
Also refactors the polyfill code, but keeps the optimizations we already had regarding not passing weeks and days to ISODateSurpasses.
(Draft; merge if tc39/proposal-intl-era-monthcode#101 is adopted)