Add testing plan guide to documentation.#4113
Merged
Conversation
ptomato
reviewed
Jun 28, 2024
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Looks like a good first draft to me. Before it's ready for publicizing there are a few things I'd suggest:
- We should make the document more approachable with a couple of introductory paragraphs, explaining what it is and who it is intended for.
- We should have a section about diminishing returns and advice on where to draw the line. See, for example, the discussion at #4054 and in Mike's testing plan guide for WPT.
- We should have a section on what steps to carry out, concretely. Things like, open a testing plan issue on the test262 repo. (Examples of good existing testing plan issues.) CC the proposal champions (if that is not you yourself). Send a PR to tc39/proposals to link the testing plan issue.
ptomato
approved these changes
Oct 31, 2024
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
This seems like really good guidance. Any other maintainers want to take a look before merging?
Ms2ger
approved these changes
Nov 1, 2024
Contributor
Ms2ger
left a comment
Ms2ger
left a comment
There was a problem hiding this comment.
Do we want to link this from somewhere?
Hopefully this will catch the notice of proposal champions working on tests for their stage 2.7 proposal.
ptomato
force-pushed
the
testing-plan-guide
branch
from
318059e to
b5ece89
Compare
Contributor
|
I added a blurb in |
gibson042
approved these changes
Apr 15, 2025
Ms2ger
approved these changes
Apr 15, 2025
ljharb
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A guide to help with writing testing plans for ECMAScript proposals in stage 2.7.