Merged
Conversation
This CL adds `Uint8Array.fromBase64()`. Bug: 42204568 Change-Id: Ib68683a2d5ead9720077197c0f895787214b183e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6026354 Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#98239}
test262-merge-bot
approved these changes
Jan 21, 2025
Contributor
test262-merge-bot
left a comment
test262-merge-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the V8 project.
Member
|
is this test not already covered by existing tests? |
Contributor
|
We didn't find tests for the various edge cases of string option handling. Got a pointer to them? |
Member
|
Gotcha, those might indeed be missing - this test seems to have all the boilerplate tho, so it could presumably be moved into the main corpus? |
Contributor
Sure, PRs welcome. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds
Uint8Array.fromBase64().Bug: 42204568
Change-Id: Ib68683a2d5ead9720077197c0f895787214b183e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6026354
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#98239}