Increase coverage for dynamic import and top-level await#4421
Merged
nicolo-ribaudo merged 3 commits intotc39:mainfrom May 8, 2025
Merged
Increase coverage for dynamic import and top-level await#4421nicolo-ribaudo merged 3 commits intotc39:mainfrom
nicolo-ribaudo merged 3 commits intotc39:mainfrom
Conversation
nicolo-ribaudo
commented
Mar 12, 2025
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
ptomato
approved these changes
May 8, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks and sorry for the long delay to review. Basically good with a few minor nitpicks.
test/language/expressions/dynamic-import/import-errored-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module-2_FIXTURE.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
test/language/module-code/top-level-await/dynamic-import-of-waiting-module.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
force-pushed
the
top-level-await
branch
from
6306f1e to
861657a
Compare
Member
Author
|
CI marks the new tests as passing in V8/SM/XS (expected) and failing in JSC (expected). Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two failing cases we found in JSC while running the import defer tests, for which we didn't have previous coverage. Given that dynamic import and top level await are features on their own, it's better to also have tests for it that do not use import defer.
What these tests are testing is that dynamic import of a module that is already rejected/pending returns a promise that is rejected/pending.