Update non-iso-calendars.js and addition-across-lunisolar-leap-months.js#4425
Merged
Update non-iso-calendars.js and addition-across-lunisolar-leap-months.js#4425
Conversation
Ms2ger
approved these changes
Mar 14, 2025
Contributor
Ms2ger
left a comment
There was a problem hiding this comment.
Thanks. I don't have time to do a full review right now, but I'll approve and wait until early next week in case anyone else has time or objections
test/staging/Intl402/Temporal/old/addition-across-lunisolar-leap-months-chinese.js
Outdated
Show resolved
Hide resolved
Also remove unnecessary check for out-dated Chinese calendar data.
ddacd2b to
842bd58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
islamic-umalqurato use dates which don't fallback toislamic-civilin ICU4C.test262/test/staging/Intl402/Temporal/old/non-iso-calendars.js
Line 548 in 7708262
chineseordangiand the underlying Temporal implementation uses out-dated Chinese calendar data...