Skip to content

Update non-iso-calendars.js and addition-across-lunisolar-leap-months.js#4425

Merged
Ms2ger merged 23 commits intotc39:mainfrom
anba:non-iso-calendars
Mar 19, 2025
Merged

Update non-iso-calendars.js and addition-across-lunisolar-leap-months.js#4425
Ms2ger merged 23 commits intotc39:mainfrom
anba:non-iso-calendars

Conversation

@anba
Copy link
Contributor

@anba anba commented Mar 14, 2025

  1. non-iso-calendars.js
  • Split into separate files for each calendar.
  • Fix various issues in the test data. For example adjusting Hijri dates to work with ICU4C and ICU4X based implementations. Or adjusting islamic-umalqura to use dates which don't fallback to islamic-civil in ICU4C.
  • Remove workarounds for old V8 versions when formatting ISO-8601 and Gregorian calendars.
  • Remove test data which are specific to ICU4C and don't necessarily reflect reality. For example Japanese eras before Meiji, which are based on questionable CLDR data.
  • It's also worth noting that most tests in "non-iso-calendars.js" were skipped, because the skip condition was wrong:
    if ((id === "chinese" || id === "dangi") && hasOutdatedChineseIcuData ) {
  • The if-condition means the test is skipped unless the current calendar is either chinese or dangi and the underlying Temporal implementation uses out-dated Chinese calendar data...
  1. addition-across-lunisolar-leap-months.js
  • Split into separate files for each calendar.
  • Remove unnecessary check for out-dated Chinese calendar data.

@anba anba requested review from a team as code owners March 14, 2025 09:31
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't have time to do a full review right now, but I'll approve and wait until early next week in case anyone else has time or objections

@anba anba force-pushed the non-iso-calendars branch from 71f3c56 to ddacd2b Compare March 14, 2025 09:49
@Ms2ger Ms2ger force-pushed the non-iso-calendars branch from ddacd2b to 842bd58 Compare March 19, 2025 12:49
@Ms2ger Ms2ger enabled auto-merge (rebase) March 19, 2025 12:50
@Ms2ger Ms2ger merged commit ce7e72d into tc39:main Mar 19, 2025
10 of 11 checks passed
@anba anba deleted the non-iso-calendars branch May 17, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants