Conversation
|
@linusg note the "relative" here. Maybe not relative to other JS engines but it's definitely had commits in the previous months so it's not entirely abandoned plus I hear there's still a community around it. Anyway I think you're making an even stronger case for its removal here. |
|
It had one commit in February, the last commit before that was in August 2024. I'm not arguing against the removal (and in fact I wish we'd remove it from https://test262.fyi already), but I think it's important to be clear about the project status here - if it was active we should encourage the team behind it to restore esvu support and re-enable CI. Since it's completely dead and that's not happening we should not pretend otherwise. |
|
I see your point that it's effectively unmaintained but not sure what to do about it apart from maybe changing the commit text. |
ptomato
left a comment
There was a problem hiding this comment.
Hmm... +1 on removing npm run test:diff:chakra. -0 on removing the commented-out CI job. -1 on removing the link to the Chakracore bug tracker. But you could replace it with the up-to-date link, https://github.com/chakra-core/ChakraCore/issues
|
Honestly I just wanted to remove it from |
053ade8 to
42a4b3d
Compare

While still a relatively active project, ChakraCore is no longer maintained by Microsoft. It's not supported by esvu anymore and it was already disabled on CI.
Also realized while making this PR that my editor automatically trimmed some unnecessary whitespace from CONTRIBUTING.md, wasn't sure if I should go back and get rid of those changes or if it's actually okay. Let me know either way.