Skip to content

Remove chakra#4438

Merged
ptomato merged 3 commits intotc39:mainfrom
ryzokuken:remove-chakra
Mar 26, 2025
Merged

Remove chakra#4438
ptomato merged 3 commits intotc39:mainfrom
ryzokuken:remove-chakra

Conversation

@ryzokuken
Copy link
Member

While still a relatively active project, ChakraCore is no longer maintained by Microsoft. It's not supported by esvu anymore and it was already disabled on CI.

Also realized while making this PR that my editor automatically trimmed some unnecessary whitespace from CONTRIBUTING.md, wasn't sure if I should go back and get rid of those changes or if it's actually okay. Let me know either way.

@ryzokuken ryzokuken self-assigned this Mar 25, 2025
@ryzokuken ryzokuken requested a review from a team as a code owner March 25, 2025 10:28
@linusg
Copy link
Member

linusg commented Mar 25, 2025

While still a relatively active project

By what metric?

image

@ryzokuken
Copy link
Member Author

@linusg note the "relative" here. Maybe not relative to other JS engines but it's definitely had commits in the previous months so it's not entirely abandoned plus I hear there's still a community around it. Anyway I think you're making an even stronger case for its removal here.

@linusg
Copy link
Member

linusg commented Mar 25, 2025

It had one commit in February, the last commit before that was in August 2024. I'm not arguing against the removal (and in fact I wish we'd remove it from https://test262.fyi already), but I think it's important to be clear about the project status here - if it was active we should encourage the team behind it to restore esvu support and re-enable CI. Since it's completely dead and that's not happening we should not pretend otherwise.

@ryzokuken
Copy link
Member Author

I see your point that it's effectively unmaintained but not sure what to do about it apart from maybe changing the commit text.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... +1 on removing npm run test:diff:chakra. -0 on removing the commented-out CI job. -1 on removing the link to the Chakracore bug tracker. But you could replace it with the up-to-date link, https://github.com/chakra-core/ChakraCore/issues

@ryzokuken
Copy link
Member Author

Honestly I just wanted to remove it from npm run test:diff because I couldn't run it without chakra, everything else is optional. I'll make the changes you suggested and break the whole thing up into multiple commits so you could take what we manage to get agreement on, but as I mentioned the only thing I actually feel strongly about is the one you're positive about.

@ptomato ptomato merged commit 6e311e4 into tc39:main Mar 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants