Fix time zone canonicalization behaviour in DateTimeFormat test#4453
Merged
Fix time zone canonicalization behaviour in DateTimeFormat test#4453
Conversation
Contributor
Author
|
cc @justingrant |
ryzokuken
approved these changes
Apr 14, 2025
Ms2ger
force-pushed
the
canonicalize-timezone
branch
from
737b6f0 to
4cfea3f
Compare
Ms2ger
approved these changes
Apr 14, 2025
As of the Time Zone Canonicalization proposal which is stage 3, the original time zone name should be preserved in Intl.DateTimeFormat .prototype.resolvedOptions. Add a separate test that uses Temporal.ZonedDateTime.prototype.equals to test the canonicalization behaviour.
ptomato
force-pushed
the
canonicalize-timezone
branch
from
4cfea3f to
ded9215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of the Time Zone Canonicalization proposal which is stage 3, the original time zone name should be preserved in Intl.DateTimeFormat .prototype.resolvedOptions.
Add a separate test that uses Temporal.ZonedDateTime.prototype.equals to test the canonicalization behaviour.