Use assertNativeFunction instead of simple regexp pattern#4462
Merged
Use assertNativeFunction instead of simple regexp pattern#4462
assertNativeFunction instead of simple regexp pattern#4462Conversation
Contributor
|
Not sure why the esmeta failure. I wonder if the same test failed on esmeta before the change. |
Ms2ger
approved these changes
Apr 29, 2025
Ms2ger
force-pushed
the
sm-function-bind-assertNativeFunction
branch
from
2229fe1 to
45c6f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/staging/sm/Function/function-bind.jstest is using a regexp pattern/^function\s*\(\)\s*\{\s*\[native code\]\s*\}$/for checking native functions.That regexp pattern doesn't match JSC's output( JSC's
Function#toStringoutput includes indentation ).So this patch changes to use
assertNativeFunction.