Conversation
ptomato
left a comment
There was a problem hiding this comment.
Reviewed up to "Remove non262-extensions-shell.js"
ptomato
left a comment
There was a problem hiding this comment.
Reviewed up to "Replace makeIterator with inline definitions"
ptomato
left a comment
There was a problem hiding this comment.
Reviewed up to "Remove assertThrownErrorContains"
…in-first-expression.js
…ntains-unicode-escape.js and fix a test bug
|
We discussed this in the test262 maintainers meeting today. We'll just go ahead and merge it; these are staging tests and so should not be held up for this long by review, and the improvements have been good so far. I'll address the existing comments, and there's one more thing I'd like to do — I'd like to convert the |
87fe7e6 to
29a218f
Compare
The history of why these tests exist can be useful context for future consumers of the test suite.
|
The following tests started to fail after this PR:
I have created #4588 to track this problem. |
Changes:
noStrictflag where possible.I've also identified a couple of tests which should be removed from test262, because they test non-standard behaviour:
Function.caller.Date.parsewith non-standard inputs.Mathfunctions are.disassembleortimeout.In a follow-up PR I can remove these tests, too.