Conversation
nicolo-ribaudo
changed the title
nicolo-ribaudo
force-pushed
the
add-test-for-module-depending-on-non-root-of-async-cycle
branch
3 times, most recently
from
bfc4c33 to
963385e
Compare
Member
Author
|
Everybody is passing this new test except for XS, cc @phoddie |
nicolo-ribaudo
force-pushed
the
add-test-for-module-depending-on-non-root-of-async-cycle
branch
from
963385e to
fbd7f63
Compare
ptomato
approved these changes
May 8, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I'm not sure if I completely understood this test, so a review from someone else would be helpful. But it looks correct.
gibson042
approved these changes
Oct 28, 2025
test/language/module-code/top-level-await/pending-async-dep-from-cycle.js
Outdated
Show resolved
Hide resolved
gibson042
force-pushed
the
add-test-for-module-depending-on-non-root-of-async-cycle
branch
from
ec5104c to
d21858b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See tc39/ecma262#3584 (comment).
This case was not previously covered by any test. I tested it by updating engine262's implementation to not "Set requiredModule to requiredModule.[[CycleRoot]]", and all existing test262 tests were still passing.
Usually the
infoof a test only contains spec text, but given that this algorithm is run 4 times by this PR and that the control flow is not trivial I wrote a more detailed explanation.