Temporal: Add coverage for getTimeZoneTransition edge cases#4466
Merged
Temporal: Add coverage for getTimeZoneTransition edge cases#4466
Conversation
gibson042
approved these changes
May 14, 2025
A "time zone transition" that is supposed to be returned by this method, is defined in the spec as an exact time where the UTC offset differs from that of the previous exact time value. Implementations reported ambiguity around rule changes in the TZDB that did not actually result in a UTC offset change. For example, a time zone changing its abbreviation, or making DST permanent. Add a test case that checks that the method does not return faulty values that would not satisfy the spec requirement of a UTC offset change. See: tc39/proposal-temporal#3105
gibson042
force-pushed
the
utc-offset-transitions
branch
from
a366023 to
185f85c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "time zone transition" that is supposed to be returned by this method, is defined in the spec as an exact time where the UTC offset differs from that of the previous exact time value.
Implementations reported ambiguity around rule changes in the TZDB that did not actually result in a UTC offset change. For example, a time zone changing its abbreviation, or making DST permanent. Add a test case that checks that the method does not return faulty values that would not satisfy the spec requirement of a UTC offset change.
See: tc39/proposal-temporal#3105