Move Map.prototype.getOrInsert tests from staging#4472
Merged
Conversation
ptomato
approved these changes
May 8, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks, these are indeed already in good shape to move out of staging.
Before merging, in each file:
- Replace
esid: proposal-upsertwithesid: sec-map.prototype.getorinsert - Remove the
noStrictflag
Contributor
There was a problem hiding this comment.
Here it'd be good to add assert.sameValue(map.get(-0), 43); at the end as well.
ljharb
approved these changes
May 9, 2025
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
confirmed these tests pass on my polyfill as well
ptomato
force-pushed
the
upsert-Map-getOrInsert
branch
from
7c8fe0d to
a22c25a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.