harness: Simplify verifyCallableProperty#4507
Merged
Conversation
Ms2ger
approved these changes
May 28, 2025
harness/propertyHelper.js
Outdated
| * @param {string} [functionName] defaults to name for strings, `[${name.description}]` for symbols | ||
| * @param {number} functionLength | ||
| * @param {PropertyDescriptor} desc | ||
| * @param {PropertyDescriptor} [desc] |
Contributor
There was a problem hiding this comment.
Please add a note about the defaults
gibson042
force-pushed
the
2025-05-simplify-verifycallableproperty
branch
from
bdc0f92 to
56cf46a
Compare
Ref tc39#4468 Match the data property defaults from https://tc39.es/ecma262/multipage/ecmascript-standard-built-in-objects.html (writable true, enumerable false, configurable true).
gibson042
force-pushed
the
2025-05-simplify-verifycallableproperty
branch
from
56cf46a to
4e69296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4468
Match the data property defaults from https://tc39.es/ecma262/multipage/ecmascript-standard-built-in-objects.html (writable true, enumerable false, configurable true).