[Temporal] Add coverage for negative months and days in from
#4799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Jan 5, 2026
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-temporal.plaindate.prototype.from |
Contributor
There was a problem hiding this comment.
Please remove .prototype from all
catamorphism
force-pushed
the
negative-months-days
branch
from
47df298 to
1697bb3
Compare
In the `from` method for the five types that can accept a month or day property, test that negative months or days throw an exception.
catamorphism
force-pushed
the
negative-months-days
branch
from
1697bb3 to
6472aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
frommethod for the five types that can accept a month or day property, test that negative months or days throw an exception.