Skip to content

web-feature classification for additional Iterator and Map features#5012

Merged
ptomato merged 1 commit intotc39:mainfrom
bocoup:webfeatures-map-iterator-updates
Apr 15, 2026
Merged

web-feature classification for additional Iterator and Map features#5012
ptomato merged 1 commit intotc39:mainfrom
bocoup:webfeatures-map-iterator-updates

Conversation

@ChrisC
Copy link
Copy Markdown
Contributor

@ChrisC ChrisC commented Apr 8, 2026

This PR maps tests for the following newer web features:

cc @jugglinmike for review

@ChrisC ChrisC requested a review from a team as a code owner April 8, 2026 17:23
Comment thread WEB_FEATURES.yml Outdated
- name: weakmap
files:
- test/built-ins/WeakMap
- "!test/built-ins/WeakMap/prototype/getOrInsert*"
Copy link
Copy Markdown
Contributor Author

@ChrisC ChrisC Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we'll have less tests mapped to weakmap as of this change to avoid overlap, so it's expected that the coverage checker will throw a warning. Theses tests are now mapped to the getorinsert feature, so there's no overall reduction in test-to-feature coverage.

@jugglinmike
Copy link
Copy Markdown
Contributor

I think using tags (upsert and iterator-sequencing) might be better here. Not so much for concision (in fact, there's a good argument to be made for the readability of an explicit list of directories) but for flexibility. The two approaches are equivalent today, but if someone adds a cross-cutting test to another directory later, then a tag-based classifier has a better chance of automatically including it. What do you think?

@ChrisC ChrisC force-pushed the webfeatures-map-iterator-updates branch from 3c1698a to 688838b Compare April 14, 2026 17:42
@ChrisC
Copy link
Copy Markdown
Contributor Author

ChrisC commented Apr 14, 2026

I think using tags (upsert and iterator-sequencing) might be better here...

@jugglinmike addressed in 688838b. How does that look?

@jugglinmike jugglinmike force-pushed the webfeatures-map-iterator-updates branch from b98543d to ebe41cf Compare April 14, 2026 21:59
@jugglinmike
Copy link
Copy Markdown
Contributor

@ptomato Can you admin-merge this?

(Context: the linter is rejecting this patch because one of matched sets is shrinking. That's intentional. We designed the linter to behave this way in the interest of avoiding unintentional regression and also to limit its complexity. That design assumes that admins can merge despite failure, though, and Test262 isn't currently configured that way--not for me, anyway. I'm also unable to push the commit to main from my local repository.)

@ptomato ptomato merged commit be10a74 into tc39:main Apr 15, 2026
13 of 14 checks passed
@jugglinmike
Copy link
Copy Markdown
Contributor

Thanks!

@jugglinmike jugglinmike deleted the webfeatures-map-iterator-updates branch April 15, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants