-
-
Notifications
You must be signed in to change notification settings - Fork 108
feat: add McDonald's Collection sets with translations and dexIds #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lamplis
wants to merge
3
commits into
tcgdex:master
Choose a base branch
from
lamplis:feat/add-mcdonalds-translations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add McDonald's Collection 2022, 2023, 2024 (15 cards each) - Add Promo McDonald's 2013, 2018, 2019 - Normalize naming from 'Macdonald's' to 'McDonald's' across all sets - Add missing dexIds to 48 Pokemon cards (2011, 2012, 2016, 2019 sets) - Add French, Spanish, Italian, German translations for set names
Member
Contributor
Author
|
Do not Merge, I need to include #102 for proper fix |
Fixes tcgdex#102 - Normalize naming from 'Macdonald's' to 'McDonald's' across all sets - Add French translations (Collection McDonald's <year>) for all sets - Rename French-only sets to 'Collection McDonald's <year> (FR)' - Complete all 259 cards across 15 McDonald's sets: - International: 2011-2019, 2021-2024 (167 cards) - French-only: 2013 FR (12), 2018 FR (40), 2019 FR (40) - Add dexIds to all Pokemon cards - Add docs/mcdonalds-alignment.md with Bulbapedia/Poképédia sources
Contributor
Author
|
#102 fixed, ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds and normalizes the McDonald's Collection promotional card sets with complete translations and Pokédex IDs.
Changes
New Sets Added
Naming Normalization
Macdonald's CollectiontoMcDonald's Collectionname.enfields to use consistentMcDonald'sspellingData Quality
dexIdentries to 48 Pokemon cards across:Translations
Validation
bun run validate✅cd server && bun run compile && bun run validate✅