feat: Refactor variant stamp structure to support details #1018
Conversation
🃏 10 Cards ChangedDetails: 10 modified, 6 without images Tropical Wind (dpp-DP05) (found using en)
File: [data/Diamond & Pearl/DP Black Star Promos/DP05.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Diamond & Pearl/DP Black Star Promos/DP05.ts) Tropical Wind (dpp-DP25) (found using en)
File: [data/Diamond & Pearl/DP Black Star Promos/DP25.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Diamond & Pearl/DP Black Star Promos/DP25.ts) Tropical Wind (dpp-DP48) (found using en)
File: [data/Diamond & Pearl/DP Black Star Promos/DP48.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Diamond & Pearl/DP Black Star Promos/DP48.ts) Shellos East Sea (dp3-106) (found using en)
File: [data/Diamond & Pearl/Secret Wonders/106.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Diamond & Pearl/Secret Wonders/106.ts) Tropical Tidal Wave (hgssp-HGSS18) (found using en) (no images)No images available for this card File: [data/HeartGold & SoulSilver/HGSS Black Star Promos/HGSS18.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/HGSS Black Star Promos/HGSS18.ts) Feraligatr (svp-213) (found using en) (no images)No images available for this card File: [data/Scarlet & Violet/SVP Black Star Promos/213.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Scarlet & Violet/SVP Black Star Promos/213.ts) Pikachu (svp-214) (found using en) (no images)No images available for this card File: [data/Scarlet & Violet/SVP Black Star Promos/214.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Scarlet & Violet/SVP Black Star Promos/214.ts) Toxtricity ex (svp-215) (found using en) (no images)No images available for this card File: [data/Scarlet & Violet/SVP Black Star Promos/215.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Scarlet & Violet/SVP Black Star Promos/215.ts) Paradise Resort (svp-224) (found using en) (no images)No images available for this card File: [data/Scarlet & Violet/SVP Black Star Promos/224.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Scarlet & Violet/SVP Black Star Promos/224.ts) Pikachu (svp-225) (found using en) (no images)No images available for this card File: [data/Scarlet & Violet/SVP Black Star Promos/225.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Scarlet & Violet/SVP Black Star Promos/225.ts) |
Updated card variant 'stamp' fields to use objects with 'stamp' and 'detail' properties for event-based stamps, replacing previous string formats. Adjusted TypeScript interfaces and translation files to support the new structure, and updated card utility logic to handle both string and object stamps for translation and display.
thomas-bassett
force-pushed
the
expand-variant-stamps
branch
from
aa000ec to
ed0a115
Compare
Replaces the 'detail' property with a 'year' property for event stamps in card data files and updates the related interface and utility function to support this change
|
not sure about this, I mean if someone want to support every stamps in their application they would still need to match the base string with their internal icon ? What does this add ? (I may have missed the convo, if so srry) |
|
We found thst there where stamps that are identical but are off to the left. Or in the case of the battle academy decks the same stamp with a different number. This was to try help with not having "pikachu-tail-01,pikachu-tail-02" the compiler still flatterns them down to a single string it just makes it a little cleaners on the database side of things. |
# Conflicts: # interfaces.d.ts # meta/translations/de.json # meta/translations/es.json # meta/translations/fr.json # meta/translations/it.json # meta/translations/pt.json
3 participants
Updated card variant 'stamp' fields to use objects with 'stamp' and 'detail' properties for event-based stamps, replacing previous string formats. Adjusted TypeScript interfaces and translation files to support the new structure, and updated card utility logic to handle both string and object stamps for translation and display.