Skip to content

Add support for "loric" role type in game logic #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ratteler50 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for "loric" role type in game logic #76

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0e64ef
Add support for "loric" role type in game logic
ratteler50 Feb 24, 2026
a0bf801
fix: set base path to relative in vite.config.ts
google-labs-jules[bot] Mar 4, 2026
6fa6e1e
fix: use relative paths for in-app navigation
google-labs-jules[bot] Mar 4, 2026
71772b1
Merge pull request #1 from ratteler50/jules-fix-base-path-18006584911…
ratteler50 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/js/botc/roles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const RoleTypes = [
"minion",
"demon",
"fabled",
"loric",
"travellers",
] as const;
Comment on lines 28 to 36
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoleTypes now includes "loric", but there are other role-type unions hardcoded elsewhere (e.g. Override.homebrew.roleType in src/js/botc/overrides.ts) that still only allow townsfolk/outsider/minion/demon/fabled/travellers. This makes the type surface inconsistent and prevents defining homebrew overrides with the new role type. Prefer reusing the shared RoleType type (or at least add "loric" to the union) so the codebase stays in sync when role types evolve.

Copilot uses AI. Check for mistakes.
export type RoleType = (typeof RoleTypes)[number];
Expand Down Expand Up @@ -70,7 +71,7 @@ export class CharacterInfo {
}

get special(): boolean {
return ["travellers", "fabled"].includes(this.roleType);
return ["travellers", "fabled", "loric"].includes(this.roleType);
}

nightDetails(firstNight: boolean): NightAction | null {
Expand Down
3 changes: 2 additions & 1 deletion src/js/botc/script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export function onlyBaseThree(characters: CharacterInfo[]): boolean {
(c) =>
c.edition != "other" ||
c.roleType == "travellers" ||
c.roleType == "fabled",
c.roleType == "fabled" ||
c.roleType == "loric",
);
}

Expand Down
2 changes: 1 addition & 1 deletion src/js/botc/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export const SetupChanges: { [key: string]: SetupModification } = {
};

export function goesInBag(withLordOfTyphon: boolean, char: CardInfo): boolean {
if (char.roleType == "fabled") {
if (char.roleType == "fabled" || char.roleType == "loric") {
return false;
}
if (withLordOfTyphon && char.roleType == "minion") {
Expand Down
2 changes: 1 addition & 1 deletion src/js/randomizer/selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function requiredSelection(characters: CharacterInfo[]): Set<string> {
required.add(demons[0].id);
}
for (const c of characters) {
if (c.roleType == "fabled") {
if (c.roleType == "fabled" || c.roleType == "loric") {
required.add(c.id);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/js/roles/character_sheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function Character(props: {
}

function pluralRole(roleType: string): string {
return ["townsfolk", "fabled", "travellers"].includes(roleType)
return ["townsfolk", "fabled", "loric", "travellers"].includes(roleType)
? roleType
: roleType + "s";
Comment on lines 118 to 121
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pluralRole takes roleType: string, but this function is only intended to handle known role types and RoleType is already imported in this file. Typing the parameter as RoleType (or RoleType | string if needed) would prevent accidental calls with arbitrary strings and make future additions like "loric" safer to roll out consistently.

Copilot uses AI. Check for mistakes.
}
Expand Down
Loading