Merge rust-bitcoin#223: Fix naming inconsistency

16114ea fix:rename invalidateblock to invalidate_block for naming consistency (oyindamola oladapo)

Pull request description:

  ### Fix missing underscore in `invalidate_block` client macro name

  This PR addresses the inconsistent naming in the client macro for the `invalidateblock` RPC method. When we updated client macro names to use underscores, `invalidateblock` was missed, likely because it was missing from the Method list due to being undocumented in the Core docs.

  Closes rust-bitcoin#215

ACKs for top commit:
  tcharding:
    ACK 16114ea

Tree-SHA512: 4ae445f5f995914dc7901e4e502c40d45c295da361718e1fa645a508ba9166b3caa1bec06af1561f151f6110113c19aac3a09ce071d1621604b20745c3de523a

Author: tcharding

client/src/client_sync/v17/generating.rs

@@ -40,7 +40,7 @@ macro_rules! impl_client_v17__generate {
 /// Implements Bitcoin Core JSON-RPC API method `invalidateblock`
 // This method does not appear in the output of `bitcoin-cli help`.
 #[macro_export]
-macro_rules! impl_client_v17__invalidateblock {
+macro_rules! impl_client_v17__invalidate_block {
     () => {
         impl Client {
             pub fn invalidate_block(&self, hash: BlockHash) -> Result<()> {

client/src/client_sync/v17/mod.rs

@@ -61,7 +61,7 @@ crate::impl_client_v17__uptime!();
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v17__generate!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v18/mod.rs

@@ -65,7 +65,7 @@ crate::impl_client_v17__uptime!();
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
 crate::impl_client_v17__generate!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v19/mod.rs

@@ -63,7 +63,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v20/mod.rs

@@ -60,7 +60,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v21/mod.rs

@@ -62,7 +62,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v22/mod.rs

@@ -62,7 +62,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v23/mod.rs

@@ -64,7 +64,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v24/mod.rs

@@ -61,7 +61,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();

client/src/client_sync/v25/mod.rs

@@ -61,7 +61,7 @@ crate::impl_client_v17__uptime!();
 
 // == Generating ==
 crate::impl_client_v17__generate_to_address!();
-crate::impl_client_v17__invalidateblock!();
+crate::impl_client_v17__invalidate_block!();
 
 // == Mining ==
 crate::impl_client_v17__get_block_template!();