Skip to content

Conversation

@rnbwdsh
Copy link

@rnbwdsh rnbwdsh commented Sep 26, 2020

Can we add an optional, default-False param to return the basis? I'd need this feature for a project.

Also I'd suggest using int(sympy.sign) instead of redefining sign. If you don't like it, only merge the first commit.

@tclose
Copy link
Owner

tclose commented Jan 26, 2021

Hi Marcus,

Sorry for the really delayed reply (I flagged the email for follow up and then never got around to it).

That change should be fine.

I note that you have removed the sign function I had defined in the module but it is still used in the return statement of the solve function. I haven't tested out your code directly, does it still work ok?

Cheers,

Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants