Skip to content

fix: rename MiniMaxi to MiniMax for correct branding#117

Merged
hanrw merged 1 commit intotddworks:mainfrom
BryanQQYue:fix/minimaxi-to-minimax-branding
Feb 15, 2026
Merged

fix: rename MiniMaxi to MiniMax for correct branding#117
hanrw merged 1 commit intotddworks:mainfrom
BryanQQYue:fix/minimaxi-to-minimax-branding

Conversation

@BryanQQYue
Copy link
Copy Markdown
Contributor

@BryanQQYue BryanQQYue commented Feb 15, 2026

Summary

Rename all code identifiers from MiniMaxi to MiniMax to match the correct brand name (minimax.io).

  • Rename files, directories, classes, protocols, provider IDs, display names, and asset names
  • Preserve API URLs (www.minimaxi.com, platform.minimaxi.com) — they are real endpoints
  • Preserve UserDefaults key strings for backward compatibility

What Changed

Before After
MiniMaxiProvider MiniMaxProvider
MiniMaxiUsageProbe MiniMaxUsageProbe
MiniMaxiSettingsRepository MiniMaxSettingsRepository
MiniMaxiRemainsResponse MiniMaxRemainsResponse
Provider ID "minimaxi" "minimax"
Display name "MiniMaxi" "MiniMax"
Asset MiniMaxiIcon MiniMaxIcon

Intentionally Unchanged

Item Reason
API URLs (www.minimaxi.com, platform.minimaxi.com) Real endpoints
UserDefaults key providerConfig.minimaxiAuthEnvVar Backward compatibility
UserDefaults key com.claudebar.credentials.minimaxi-api-key Backward compatibility
Method names minimaxiAuthEnvVar(), saveMinimaxiApiKey(), etc. Tied to UserDefaults keys

Test Plan

  • tuist build passes
  • tuist test — all tests pass
  • grep -ri "minimaxi" Sources/ Tests/ confirms only API URLs and UserDefaults keys remain

Closes #116

Summary by CodeRabbit

  • Bug Fixes

    • Corrected provider-to-icon mapping and updated asset references so the MiniMax provider displays the proper icon.
  • Refactor

    • Renamed branding and identifiers from "MiniMaxi" to "MiniMax" across the app—UI labels, settings, visual identity, and assets updated for consistency.
  • Tests

    • Updated provider-related tests and probes to align with the new MiniMax naming (no behavioral changes).

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 15, 2026

📝 Walkthrough

Walkthrough

Rename of the MiniMaxi provider to MiniMax across the codebase: types, protocol names, provider IDs, asset filenames, UI identifiers, theme mappings, and tests updated from "MiniMaxi"/"minimaxi" to "MiniMax"/"minimax".

Changes

Cohort / File(s) Summary
Provider Core Implementation
Sources/Domain/Provider/MiniMax/MiniMaxProvider.swift, Sources/Domain/Provider/ProviderSettingsRepository.swift, Sources/Infrastructure/MiniMax/MiniMaxUsageProbe.swift, Sources/Infrastructure/Storage/UserDefaultsProviderSettingsRepository.swift
Renamed public types and protocol (MiniMaxi→MiniMax), removed @Observable from provider class, changed settings repository types to MiniMaxSettingsRepository, and updated provider id/name from "minimaxi"/MiniMaxi to "minimax"/MiniMax.
App Configuration & Assets
Sources/App/ClaudeBarApp.swift, Sources/App/Resources/Assets.xcassets/MiniMaxIcon.imageset/Contents.json
Replaced use of MiniMaxiProvider/MiniMaxiUsageProbe with MiniMaxProvider/MiniMaxUsageProbe in AIProviders initialization; renamed image filenames from minimaxi_*minimax_* in asset catalog.
UI & Visual Identity
Sources/App/Views/ProviderIcons.swift, Sources/App/Views/ProviderVisualIdentity.swift, Sources/App/Views/SettingsView.swift, Sources/App/Views/Theme.swift
Updated provider identifier literals and mappings from minimaximinimax, renamed visual identity extension to MiniMaxProvider, switched asset/symbol names to MiniMax/MiniMaxIcon, and renamed SettingsView state/labels/functions to MiniMax naming.
Tests
Tests/InfrastructureTests/MiniMax/... Tests/InfrastructureTests/MiniMax/MiniMaxUsageProbeParsingTests.swift, Tests/InfrastructureTests/MiniMax/MiniMaxUsageProbeTests.swift
Renamed test suites and references from MiniMaxiUsageProbe*MiniMaxUsageProbe*, updated parse/test expectations and providerId literals from "minimaxi""minimax".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 I hopped through code with nimble paws,
A tiny rename, with no faux pas.
From MiniMaxi to MiniMax bright,
Icons and tests now feel just right.
Hooray — a carrot-coded delight!

🚥 Pre-merge checks | ✅ 5 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 65.22% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming MiniMaxi to MiniMax for correct branding, which is the primary objective of this PR.
Linked Issues check ✅ Passed The PR fully addresses issue #116 by renaming all code identifiers, files, and display names from MiniMaxi to MiniMax while preserving backward compatibility for API URLs and UserDefaults keys.
Out of Scope Changes check ✅ Passed All changes are directly related to renaming MiniMaxi to MiniMax across the codebase; no unrelated modifications detected beyond the stated objectives.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The correct brand name is MiniMax (https://www.minimax.io/), not MiniMaxi.
Renamed all code identifiers (classes, protocols, files, directories,
display names, provider IDs, asset names) from MiniMaxi to MiniMax.

API URLs (www.minimaxi.com, platform.minimaxi.com) and UserDefaults key
strings are preserved unchanged for backward compatibility.

Closes tddworks#116
@BryanQQYue BryanQQYue force-pushed the fix/minimaxi-to-minimax-branding branch from 54c400a to 21923cd Compare February 15, 2026 13:19
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2026

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.46%. Comparing base (816aaf7) to head (21923cd).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ces/Infrastructure/MiniMax/MiniMaxUsageProbe.swift 90.47% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   78.34%   78.46%   +0.12%     
==========================================
  Files          77       77              
  Lines        5832     5832              
==========================================
+ Hits         4569     4576       +7     
+ Misses       1263     1256       -7     
Files with missing lines Coverage Δ
...s/Domain/Provider/ProviderSettingsRepository.swift 100.00% <ø> (ø)
...orage/UserDefaultsProviderSettingsRepository.swift 83.91% <ø> (ø)
...ces/Infrastructure/MiniMax/MiniMaxUsageProbe.swift 95.78% <90.47%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanrw hanrw merged commit 4f36629 into tddworks:main Feb 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MiniMax instead of MiniMaxi

2 participants