Conversation
|
Replace Biome with OXC toolchain for linting and formatting: - oxlint for linting with rules mirroring the existing Biome config - oxfmt for formatting with matching style (single quotes, 80 width, trailing commas) - Enable suspicious category at warn level for additional code quality checks - Add eqeqeq (smart mode for null checks), no-console, import/no-duplicates - Disable react-in-jsx-scope (React 19 JSX transform) - Configure no-unused-vars to allow _ prefixed params (convention) - Convert 25 biome-ignore comments to oxlint equivalents (7 removed as unneeded) - Update CI, lint-staged, VS Code settings accordingly
30c9a6b to
1e9b690
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
- Coverage 92.96% 92.95% -0.01%
==========================================
Files 73 73
Lines 1478 1477 -1
Branches 259 256 -3
==========================================
- Hits 1374 1373 -1
Misses 94 94
Partials 10 10
🚀 New features to boost your workflow:
|
- Change `import type React` to `import React` in 7 files across react-broadcast and react-redux where React is used as a JSX value - Format tooling/test-utils/package.json with oxfmt (key reordering)
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project's linting and formatting infrastructure from Biome to oxc (oxlint and oxfmt). The changes include removing Biome configuration, adding oxc configuration files, updating all lint directive comments throughout the codebase, applying consistent formatting changes, and reordering package.json fields to match oxfmt's conventions.
Changes:
- Replaced Biome with oxc tooling (oxlint and oxfmt)
- Updated all lint suppression comments from
biome-ignoretooxlint-disablesyntax - Applied consistent formatting changes (trailing commas, blank lines, quote normalization)
- Reordered package.json fields across all packages for consistency
- Updated scripts, workflows, and IDE configuration
Reviewed changes
Copilot reviewed 142 out of 143 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| biome.json | Removed Biome configuration |
| .oxlintrc.json | Added oxlint configuration with rules and plugins |
| .oxfmtrc.json | Added oxfmt formatting configuration |
| .vscode/settings.json | Updated to use oxc-vscode extension |
| lint-staged.config.mjs | Updated to use oxlint and oxfmt instead of biome |
| package.json | Updated scripts and dependencies; reordered fields |
| packages/*/package.json | Standardized field ordering across all packages |
| packages//src/.ts(x) | Updated lint comments; added trailing commas and blank lines |
| packages//test/.js(x) | Updated lint comments; formatting adjustments |
| packages/splitio-adapter/src/adapter.ts | Simplified conditional logic in normalizeFlag function |
| packages/react-broadcast/src/use-all-feature-toggles.ts | Changed .reverse() to .toReversed() |
| packages/react-redux/src/use-all-feature-toggles.ts | Changed .reverse() to .toReversed() |
| packages/react-broadcast/src/test-provider.tsx | Removed unnecessary spread operator |
| packages/graphql-adapter/src/adapter.ts | Simplified optional chaining |
| readme.md | Quote style normalization; table formatting |
| openspec/*.md | Markdown formatting adjustments |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary