Open
Conversation
Collaborator
|
I like the idea of using a callback, but we just have to make sure that usage inside "not" and other "non-cascading" keywords doesn't impact the root call. We want most errors to bubble all the way up, just not that one. |
Collaborator
|
Today I'll push a patch release for #363 with no additional changes. Then sometime next week I'll push a feature release that re-uses the errors array, and adds the "onError" callback. Cascading the errors array doesn't seem to save that much memory, but it ensures that non-cascading sub-schemas ("not", "if", "oneOf" etc.) are properly isolated from their parent, which is necessary to add this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enhancement request + PR in one:
The goal is to stop validating after 200 errors. Instead of hard-coding that number, and instead of a specific option like
throwAfter: 200, a genericonErrorcallback can be the building block to enable this.To stop after 200 errors we could do something like this:
onError: () => { if (++count >= 200) { throw ... } }.