Update the region post items to avoid long lore or display names#21
Open
ianpalencar wants to merge 1 commit intotdfischer:masterfrom
Open
Update the region post items to avoid long lore or display names#21ianpalencar wants to merge 1 commit intotdfischer:masterfrom
ianpalencar wants to merge 1 commit intotdfischer:masterfrom
Conversation
…ch could cause the tooltips to run off of the screen
Author
|
I used the wrong e-mail for the commit on the prior pull request, so figured I'd change it~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Update several spots in the post UI to either truncate, wordwrap, or shorten the wording overall. It seems like the maximum string length for these UI elements is roughly 48 characters.
I also added persistent data container usage to handle the full name of the post, as the truncation of long display names was preventing teleportation from working at all. this might also be a reasonable approach for fixing the configuration item.