Open
Conversation
Ensure hub to hub travel is free Fix the discount logic so it actually displays discounts Add some tests
ianpalencar
commented
Sep 16, 2021
|
|
||
| public class RegionTest { | ||
|
|
||
| private World world = Mockito.mock(World.class); |
Author
There was a problem hiding this comment.
The world isn't actually needed, the location computation code does a check that it's not null and a by-reference equals to make sure that the distance is being computed within the same world. Otherwise nothing's needed on it, hence the mockito voodoo.
Author
|
Oh also I should note I didn't test this, so I should probably do that before it gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Ensure hub to hub travel is free
Fix the discount logic so it actually displays discounts
Add some tests