Skip to content

Conversation

@jdenis-invn
Copy link
Collaborator

@jdenis-invn jdenis-invn commented Apr 3, 2025

Add Build checker and version checker to soniclib public repo CI

@jdenis-invn jdenis-invn requested a review from a team as a code owner April 3, 2025 13:51
@jdenis-invn jdenis-invn self-assigned this Apr 3, 2025
@mhkline
Copy link
Contributor

mhkline commented Apr 3, 2025

What's the deal with the ubuntu build?

@jdenis-invn
Copy link
Collaborator Author

@mhkline
An error is raised because the last tag (for documentation) is 4.5.0 and the version on the code base is 4.4.7 :
Extracted project version : 4.4.7 Latest GitHub release tag : 4.5.0

On the main branch the soniclib version is still 4.4.7 and I used this branch for my dev branch.

@mhkline
Copy link
Contributor

mhkline commented Apr 3, 2025

@jdenis-invn

Ah, so you found the first bug with our flow.

This is a real issue that occasionally happens. The reason is that the github pages documentation is immediately updated upon building a new release on the Jenkins side, while the actual source code is not. On the source code side, Jenkins creates a new branch with the changes and does not immediately merge this to main.

Unfortunately, I think changing this behavior is quite complex. We have considered trying to keep older versions of the documentation available, but I don't think anyone has really spent time on this yet.

I think we may need to disable the check on the github pages documentation version for now.

@gjabouley-invn FYI

@jdenis-invn
Copy link
Collaborator Author

Ahah, ok, so, i will disable this check if the last tag is a documentation tag.

@jdenis-invn
Copy link
Collaborator Author

@mhkline If it's ok with you, I'll wait for @gjabouley-invn to get back before merging this branch.

@gjabouley-invn
Copy link
Contributor

@mhkline i'll have a look, let's try to finalize this topic so we have a working build for this public repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants